Project

General

Profile

GX-Bug #67987

Invalid product links lead to an error message if no error page has been activated | Ungültige Produktlinks führen zu einer Fehlermeldung, sofern keine Fehlerseite aktiviert wurde

Added by Moritz Bunjes 10 months ago. Updated about 2 months ago.

Status:
Erledigt
Priority:
Normal
Assignee:
Category:
Frontend
Target version:
% Done:

0%

Estimated time:
Steps to reproduce:
Betroffene Versionen:
4.3.1.0
Release Notes Langtext:

Ungültige Produktlinks können keine Fehlermeldung mehr verursachen


Description

An invalid product url can cause an error message like this:

Uncaught Exception: Product ID can't be 0 in /var/www/html/feature/src/GambioShop/Product/ValueObjects/ProductId.php:37
Stack trace:
#0 /var/www/html/feature/src/GambioShop/Product/SellingUnit/Database/Listener/OnSellingUnitIdCreateListener.php(29): Gambio\Shop\Product\ValueObjects\ProductId->__construct()
#1 /var/www/html/feature/src/GambioCore/Event/EventDispatcher.php(62): Gambio\Shop\Product\SellingUnit\Database\Listener\OnSellingUnitIdCreateListener->__invoke()
#2 /var/www/html/feature/src/GambioShop/SellingUnit/Unit/Factories/SellingUnitIdFactory.php(88): Gambio\Core\Event\EventDispatcher->dispatch()
#3 /var/www/html/feature/src/product_info.php(105): Gambio\Shop\SellingUnit\Unit\Factories\SellingUnitIdFactory->createFromCustom()
#4 {main}
  thrown

Steps to reproduce:

  1. deactivate the error page for missing contents (Gambio Admin > Content > Own Error Pages)
  2. activate seo boost urls for products (Gambio Admin > Settings -> search for "seo" -> Activate search engine friendly URLs for the article page)
  3. open an invalid product link like http://your-shop-url/invalid.html

Expected:
A shop page is shown saying the product was not found

Actual:
An error message is displayed.


Files

2020-11-26_12-20.png (47.8 KB) 2020-11-26_12-20.png invalid product url causes error message Moritz Bunjes, 11/26/2020 12:20 PM
2020-11-26_12-19.png (72.3 KB) 2020-11-26_12-19.png seo setting Moritz Bunjes, 11/26/2020 12:20 PM
2020-11-26_12-17.png (65.2 KB) 2020-11-26_12-17.png deactivating error page Moritz Bunjes, 11/26/2020 12:20 PM
2020-11-26_12-30.png (40.6 KB) 2020-11-26_12-30.png expected result page Moritz Bunjes, 11/26/2020 12:30 PM

Related issues

Copied from GX-Entwicklung - GX-Bug #67969: Invalid product links lead to an error message if no error page has been activated | Ungültige Produktlinks führen zu einer Fehlermeldung, sofern keine Fehlerseite aktiviert wurdeErledigt

Actions

History

#1

Updated by Moritz Bunjes 10 months ago

  • Copied from GX-Bug #67969: Invalid product links lead to an error message if no error page has been activated | Ungültige Produktlinks führen zu einer Fehlermeldung, sofern keine Fehlerseite aktiviert wurde added
#2

Updated by Marvin Muxfeld 10 months ago

  • Status changed from Anerkannt to In Bearbeitung
  • Assignee set to Marvin Muxfeld
#3

Updated by Marvin Muxfeld 10 months ago

  • Status changed from In Bearbeitung to Testing
  • Assignee changed from Marvin Muxfeld to Core-Entwickler
  • Target version changed from SP-Candidates to 4.2.1.0 beta1
#4

Updated by Ahmed Hamouda 10 months ago

  • Assignee changed from Core-Entwickler to Ahmed Hamouda
#5

Updated by Ahmed Hamouda 10 months ago

  • Status changed from Testing to Erledigt
#6

Updated by Moritz Bunjes 9 months ago

  • Tags changed from stable, 4.2.0.2 to 4.2.0.2
#7

Updated by Moritz Bunjes about 2 months ago

  • Tags deleted (4.2.0.2)

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 5 MB)