Project

General

Profile

Actions
Copy link

GX-Bug #67949

closed

Fetching the "direct help" links should have a fallback | Sollten die Direkthilfe-Links nicht abgerufen werden können, sollte es zu keinem Fehler kommen, sondern ein Fallback greifen

Added by Moritz Bunjes almost 4 years ago. Updated about 3 years ago.

Status:
Erledigt
Priority:
Hoch
Assignee:
Marvin Muxfeld
Category:
Adminbereich
Target version:
4.3.2.0 beta1
% Done:

0%

Estimated time:
Steps to reproduce:
Betroffene Versionen:
4.3.1.0
Release Notes Langtext:

Die Direkthilfe im Gambio Admin funktioniert nun zuverlässiger

Tags:
Fix

Description

Installing and activating the "Direct help" module in the Module Center of the Gambio Admin displays a help icon in the bottom right corner. The icon links to the corresponding page in the online manual. The link is stored on a remote server. It may happen, that the remote server is not available or the response is invalid. In this case a fallback should be applied (linking to the start page of the online manual).

To reproduce the bug, you have to fake an invalid response, by changing the shopVersion parameter in the file

src/GXModules/Gambio/DirectHelp/Admin/Classes/Storages/DirectHelpManualMappingFileStorage.inc.php:180

Change 

$url     = $this->remoteLocation . '?shopVersion=' . $this->shopVersion;

to

$url     = $this->remoteLocation . '?shopVersion=invalid' . $this->shopVersion;

A fix is attached as a patch file. Without the fix a call of admin/admin.php?do=DirectHelpProxy/GoToManual causes an error instead of being redirected to the online manual.

Files

Download all files
Bildschirmfoto von 2020-11-19 18-03-21.png (6.67 KB) Bildschirmfoto von 2020-11-19 18-03-21.png Moritz Bunjes, 11/19/2020 06:07 PM
direct_help_fallback_patch.patch (1.8 KB) direct_help_fallback_patch.patch Moritz Bunjes, 11/19/2020 06:07 PM

Related issues

Copied to GX-Entwicklung - GX-Bug #68013: Fetching the "direct help" links should have a fallback | Sollten die Direkthilfe-Links nicht abgerufen werden können, sollte es zu keinem Fehler kommen, sondern ein Fallback greifenErledigtMoritz Bunjes

Actions
Actions
Copy link
 #1

Updated by Moritz Bunjes almost 4 years ago

  • Subject changed from Sollten die Direkthilfe-Links nicht abgerufen werden können, sollte es zu keinem Fehler kommen, sondern ein Fallback greifen to Fetching the "direct help" links should have a fallback | Sollten die Direkthilfe-Links nicht abgerufen werden können, sollte es zu keinem Fehler kommen, sondern ein Fallback greifen
Actions
Copy link
 #2

Updated by Moritz Bunjes almost 4 years ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Moritz Bunjes almost 4 years ago

  • Description updated (diff)
Actions
Copy link
 #4

Updated by Ulrich Wenk almost 4 years ago

  • Status changed from Gemeldet to Feedback
  • Assignee set to Moritz Bunjes

Couldn't be reproduced

Actions
Copy link
 #5

Updated by Moritz Bunjes almost 4 years ago

  • Tags changed from Fix to Fix, 4.2.0.2, 4.3.2.0 beta1
  • Status changed from Feedback to Gemeldet
  • Assignee deleted (Moritz Bunjes)
Actions
Copy link
 #6

Updated by Moritz Bunjes almost 4 years ago

  • Status changed from Gemeldet to In Bearbeitung
  • Assignee set to Moritz Bunjes
Actions
Copy link
 #7

Updated by Moritz Bunjes almost 4 years ago

  • Status changed from In Bearbeitung to Testing
  • Assignee changed from Moritz Bunjes to Core-Entwickler
  • Target version changed from 133 to 4.3.2.0 beta1
  • Release Notes Langtext updated (diff)
  • Betroffene Versionen 4.3.1.0 added
  • Betroffene Versionen deleted (Unbestimmt)
Actions
Copy link
 #8

Updated by Marvin Muxfeld almost 4 years ago

  • Assignee changed from Core-Entwickler to Marvin Muxfeld
Actions
Copy link
 #9

Updated by Marvin Muxfeld almost 4 years ago

  • Status changed from Testing to Erledigt
Actions
Copy link
 #10

Updated by Moritz Bunjes almost 4 years ago

  • Copied to GX-Bug #68013: Fetching the "direct help" links should have a fallback | Sollten die Direkthilfe-Links nicht abgerufen werden können, sollte es zu keinem Fehler kommen, sondern ein Fallback greifen added
Actions
Copy link
 #11

Updated by Moritz Bunjes almost 4 years ago

  • Tags changed from Fix, 4.2.0.2, 4.3.2.0 beta1 to Fix, 4.3.2.0 beta1
Actions
Copy link
 #12

Updated by Moritz Bunjes about 3 years ago

  • Tags changed from Fix, 4.3.2.0 beta1 to Fix
Actions
Copy link

Also available in: Atom PDF