Project

General

Profile

GX-Bug #66946

Validation in SE4 Color-Picker does not recognize all allowed values

Added by Till Tepelmann 12 months ago. Updated 10 months ago.

Status:
Erledigt
Priority:
Hoch
Assigned To:
Category:
StyleEdit 4
Target version:
% Done:

0%

Estimated time:
Steps to reproduce:
Betroffene Versionen:
4.1.1.0
Release Notes Langtext:

Die Validierung von Farbwerten im StyleEdit wurde korrigiert

Story points-Velocity based estimate-

Description

Validation in SE4 Color-Picker does not recognize all allowed values

Wenn man SCSS Funktionen im SE4 Color-Picker einträgt, dann werden diese nicht korrekt erkannt. Hier sollten folgende Werte möglich sein:

  1. Farben mit Namen wie z.B. "red", "green", "yellow" usw.
  2. Farben mit "#", die 3 oder 6 stelligen HEX Code haben
  3. SCSS Variablen mit $ wie z.B. "$brand-primary"
  4. SCSS Funktionen wie z.B. "darken()" usw.

Eine mögliche Implementierung könnte ein RegEx sein der die Felder auf gültigen Eingeben überprüft.

Es waren bereits schon die ersten 3 implementiert, hier muss nur noch die 4. Option implementiert werden und der verlinkte Commit muss damit wieder revertet werden, da wir auf diesen aufbauen sollten.


If you enter SCSS functions in the SE4 Color Picker, they are not recognized correctly. Here the following values should be possible:

  1. colors with names such as "red", "green", "yellow" etc.
  2. colors with "#" that have 3 or 6 digit HEX code
  3. SCSS variables with $ like $brand-primary
  4. SCSS functions such as "darken()" etc.

A possible implementation could be a RegEx which checks the fields for valid input.

The first 3 were already implemented, here only the 4th option needs to be implemented and the linked commit needs to be reverted, because we should build on them.


Files

SE4-color-picker-issue.JPG (242 KB) SE4-color-picker-issue.JPG Ulrich Wenk, 05/19/2020 06:20 PM

Related issues

Copied from GX-Entwicklung - GX-Bug #66897: SE4 color-picker issue default values with scss function are marked as invalid entriesErledigt

Actions
Copied to GX-Entwicklung - GX-Bug #67324: Validation in SE4 Color-Picker does not recognize all allowed valuesErledigt

Actions

History

#1

Updated by Till Tepelmann 12 months ago

  • Copied from GX-Bug #66897: SE4 color-picker issue default values with scss function are marked as invalid entries added
#3

Updated by Ulrich Wenk 11 months ago

  • Status changed from Gemeldet to Anerkannt
#4

Updated by Alexandre Ataides 11 months ago

  • Assigned To set to Alexandre Ataides
#5

Updated by Alexandre Ataides 11 months ago

  • Status changed from Anerkannt to Testing
  • Assigned To changed from Alexandre Ataides to Core-Entwickler
  • Target version changed from SP-Candidates to 4.1.2.0
#6

Updated by Ronald Loyko 11 months ago

  • Assigned To changed from Core-Entwickler to Ronald Loyko
#7

Updated by Ronald Loyko 11 months ago

  • Status changed from Testing to Erledigt
#8

Updated by Ahmed Hamouda 10 months ago

  • Copied to GX-Bug #67324: Validation in SE4 Color-Picker does not recognize all allowed values added
#9

Updated by Ahmed Hamouda 10 months ago

  • Tags deleted (stable)

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 5 MB)